On Thu, Feb 11, 2016 at 12:34:15PM -0700, Jason Gunthorpe wrote: > On Tue, Feb 09, 2016 at 05:30:30AM +0200, Jarkko Sakkinen wrote: > > If the initialization fails before tpm_chip_register(), put_device() > > will be not called, which causes release callback not to be called. > > This patch fixes the issue by adding put_device() to devres list of > > the parent device. > > > > Fixes: 313d21eeab ("tpm: device class for tpm") > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx> > > cc: stable@xxxxxxxxxxxxxxx > > drivers/char/tpm/tpm-chip.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c > > index 1a9dcee..ea904d1 100644 > > +++ b/drivers/char/tpm/tpm-chip.c > > @@ -136,6 +136,8 @@ struct tpm_chip *tpmm_chip_alloc(struct device *dev, > > chip->cdev.owner = chip->pdev->driver->owner; > > chip->cdev.kobj.parent = &chip->dev.kobj; > > > > + devm_add_action(dev, (void (*)(void *)) put_device, &chip->dev); > > + > > Erm, don't forget the error handling here. > > Something like this: > > rc = devm_add_action(dev, (void (*)(void *)) put_device, &chip->dev); > if (rc) { > put_device(&chip->dev); > return ERR_PTR(rc); > } I'll implement that as a separate commit since it is already in pull request. Thanks. /Jarkko -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html