Re: [added to the 4.1 stable tree] ARM: OMAP2+: Fix l2_inv_api_params for rodata

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/11/2016 05:41 AM, Russell King - ARM Linux wrote:
> On Thu, Feb 11, 2016 at 04:55:37AM +0000, Woodruff, Richard wrote:
>>> > > From: Sasha Levin [mailto:sasha.levin@xxxxxxxxxx]
>>> > > Sent: Wednesday, February 10, 2016 9:11 AM
>> > 
>> > Did you test these changes?
>> > 
>>> > > We don't want to write to .text, so let's move l2_inv_api_params
>>> > > to .data and access it via a pointer.
>> > 
>> > At one point in time some of these functions were copied from DRAM load
>> > address into SRAM and executed from there.
>> > 
>> > Some of these sections had to be executed outside of DDR due to issues.
>> > The copy assumed contagious section.  If you move some of the data into
>> > a separate section and any copy is still in code the result won't work
>> > as expected.  If the code has changed then maybe its OK.   Back when
>> > this code was entered it was hand stepped to ensure correct behavior. 
> Yes, this isn't going to work if it is copied out of the DDR, because
> moving the data to the .data section and introducing a PC relative
> access to it will make the code expect to access data at a relative
> offset from the SRAM.
> 
> Sascha, please drop this for now.

Dropped.


Thanks,
Sasha
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]