Re: Backport of "xhci: Disable D3cold for buggy TI redrivers."

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sarah,

Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx> writes:

> On Fri, Jun 07, 2013 at 03:04:43PM +0100, Luis Henriques wrote:
>> Hi,
>> 
>> While working on 3.5 kernel, I came across commit
>> 
>> c3897aa5386faba77e5bbdf94902a1658d3a5b11 xhci: Disable D3cold for buggy TI redrivers.
>> 
>> which states:
>> 
>>     This patch should be backported to kernels as old as 3.2, that
>>     contain the commit 71c731a296f1b08a3724bd1b514b64f1bda87a23 "usb: host:
>>     xhci: Fix Compliance Mode on SN65LVPE502CP Hardware"
>> 
>> However, this commit actually makes usage of no_d3cold field in
>> struct pci_dev, which doesn't exist in older kernels:
>> 
>> +       if (xhci_compliance_mode_recovery_timer_quirk_check())
>> +               pdev->no_d3cold = true;
>> 
>> Could someone advise on this?  If this patch really is applicable to
>> this kernel, can we get some help on the backport (at least for the
>> 3.2, 3.4 and 3.5 kernels)?
>
> If the stable kernel doesn't include support for D3 cold, you don't need
> that patch.  Ying, when did D3 cold support go in?

I believe the D3 cold support was implemented with commit

448bd857d48e69b33ef323739dc6d8ca20d4cda7 PCI/PM: add PCIe runtime D3cold support

Which, according to git, was introduced in 3.6:

 $ git name-rev --name-only 448bd857d48e69b33ef323739dc6d8ca20d4cda7
 tags/v3.6-rc1~112^2~9^2~1

Assuming the above is correct, commit c3897aa5386faba77e5bbdf94902a1658d3a5b11
does not require to be backported to older kernels even if they
contain 71c731a296f1b08a3724bd1b514b64f1bda87a23, contradicting the
commit text.  Is this correct?

Cheers,
-- 
Luis
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]