Patch "ALSA: hda - Flush the pending probe work at remove" has been added to the 4.4-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    ALSA: hda - Flush the pending probe work at remove

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     alsa-hda-flush-the-pending-probe-work-at-remove.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.


>From 991f86d7ae4e1f8c15806e62f97af519e3cdd860 Mon Sep 17 00:00:00 2001
From: Takashi Iwai <tiwai@xxxxxxx>
Date: Wed, 20 Jan 2016 17:19:02 +0100
Subject: ALSA: hda - Flush the pending probe work at remove

From: Takashi Iwai <tiwai@xxxxxxx>

commit 991f86d7ae4e1f8c15806e62f97af519e3cdd860 upstream.

As HD-audio driver does deferred probe internally via workqueue, the
driver might go into the mixed state doing both probe and remove when
the module gets unloaded during the probe work.  This eventually
triggers an Oops, unsurprisingly.

For avoiding this race, we just need to flush the pending probe work
explicitly before actually starting the resource release.

Bugzilla: https://bugzilla.opensuse.org/show_bug.cgi?id=960710
Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

---
 sound/pci/hda/hda_intel.c |   10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2126,9 +2126,17 @@ i915_power_fail:
 static void azx_remove(struct pci_dev *pci)
 {
 	struct snd_card *card = pci_get_drvdata(pci);
+	struct azx *chip;
+	struct hda_intel *hda;
+
+	if (card) {
+		/* flush the pending probing work */
+		chip = card->private_data;
+		hda = container_of(chip, struct hda_intel, chip);
+		flush_work(&hda->probe_work);
 
-	if (card)
 		snd_card_free(card);
+	}
 }
 
 static void azx_shutdown(struct pci_dev *pci)


Patches currently in stable-queue which might be from tiwai@xxxxxxx are

queue-4.4/alsa-hrtimer-fix-stall-by-hrtimer_cancel.patch
queue-4.4/alsa-hda-fix-white-noise-on-dell-latitude-e5550.patch
queue-4.4/alsa-hda-fix-the-headset-mic-detection-problem-for-a-dell-laptop.patch
queue-4.4/alsa-timer-harden-slave-timer-list-handling.patch
queue-4.4/alsa-timer-fix-double-unlink-of-active_list.patch
queue-4.4/alsa-control-avoid-kernel-warnings-from-tlv-ioctl-with-numid-0.patch
queue-4.4/alsa-hda-flush-the-pending-probe-work-at-remove.patch
queue-4.4/alsa-hda-fixup-inverted-internal-mic-for-lenovo-e50-80.patch
queue-4.4/alsa-usb-add-native-dsd-support-for-oppo-ha-1.patch
queue-4.4/alsa-hda-fix-missing-module-loading-with-model-generic-option.patch
queue-4.4/alsa-seq-fix-race-at-timer-setup-and-close.patch
queue-4.4/alsa-pcm-fix-snd_pcm_hw_params-struct-copy-in-compat-mode.patch
queue-4.4/alsa-seq-fix-snd_seq_call_port_info_ioctl-in-compat-mode.patch
queue-4.4/alsa-seq-fix-missing-null-check-at-remove_events-ioctl.patch
queue-4.4/alsa-usb-audio-fix-mixer-ctl-regression-of-native-instrument-devices.patch
queue-4.4/alsa-timer-handle-disconnection-more-safely.patch
queue-4.4/alsa-hda-fix-bass-pin-fixup-for-asus-n550jx.patch
queue-4.4/alsa-timer-fix-race-among-timer-ioctls.patch
queue-4.4/alsa-hda-add-fixup-for-dell-latitidue-e6540.patch
queue-4.4/alsa-usb-audio-avoid-calling-usb_autopm_put_interface-at-disconnect.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]