On Fri, Jun 07, 2013 at 03:23:04PM -0700, gregkh@xxxxxxxxxxxxxxxxxxx wrote: > > The patch below does not apply to the 3.9-stable tree. > If someone wants it applied there, or to any other stable or longterm > tree, then please email the backport, including the original git commit > id to <stable@xxxxxxxxxxxxxxx>. > > thanks, > > greg k-h > > ------------------ original commit in Linus's tree ------------------ > > From 022d0547aa8b00ff5035ba6207ebc2c08ea0a51f Mon Sep 17 00:00:00 2001 > From: Peter Chen <peter.chen@xxxxxxxxxxxxx> > Date: Fri, 24 May 2013 14:30:16 +0800 > Subject: [PATCH] usb: dwc3: exynos: PHY should be deleted later than dwc3 core > > If the glue layer is removed first (core layer later), > it deletes the phy device first, then the core device. > But at core's removal, it still uses PHY's resources, it may > cause kernel's oops. It is much like the problem > Paul Zimmerman reported at: > http://marc.info/?l=linux-usb&m=136547502011472&w=2. > > Besides, it is reasonable the PHY is deleted at last as > the controller is the PHY's user. > > Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx> > Cc: <stable@xxxxxxxxxxxxxxx> > Signed-off-by: Felipe Balbi <balbi@xxxxxx> my mistake. I should have checked before accepting the Cc stable tag. The bug was not there in v3.9. Looking at the git blame, when I added basic PHY support, I added it properly: fb4e98ab (Bill Pemberton 2012-11-19 13:26:20 -0500 169) static int dwc3_exynos_remove(struct platform_device *pdev) d28a9689 (Anton Tikhomirov 2012-02-15 17:04:56 +0900 170) { d28a9689 (Anton Tikhomirov 2012-02-15 17:04:56 +0900 171) struct dwc3_exynos *exynos = platform_get_drvdata(pdev); d28a9689 (Anton Tikhomirov 2012-02-15 17:04:56 +0900 172) d28a9689 (Anton Tikhomirov 2012-02-15 17:04:56 +0900 173) platform_device_unregister(exynos->dwc3); d720f057 (Felipe Balbi 2012-07-19 14:01:10 +0300 174) platform_device_unregister(exynos->usb2_phy); d720f057 (Felipe Balbi 2012-07-19 14:01:10 +0300 175) platform_device_unregister(exynos->usb3_phy); d28a9689 (Anton Tikhomirov 2012-02-15 17:04:56 +0900 176) d28a9689 (Anton Tikhomirov 2012-02-15 17:04:56 +0900 177) clk_disable(exynos->clk); d28a9689 (Anton Tikhomirov 2012-02-15 17:04:56 +0900 178) d28a9689 (Anton Tikhomirov 2012-02-15 17:04:56 +0900 179) return 0; d28a9689 (Anton Tikhomirov 2012-02-15 17:04:56 +0900 180) } This commit can be safely ignored. -- balbi
Attachment:
signature.asc
Description: Digital signature