This is a note to let you know that I've just added the patch titled
netlink: Add missing goto statement to netlink_insert
to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
netlink-add-missing-goto-statement-to-netlink_insert.patch
and it can be found in the queue-4.1 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From herbert@xxxxxxxxxxxxxxxxxxx Tue Dec 8 22:28:59 2015
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 8 Dec 2015 14:13:19 +0800
Subject: netlink: Add missing goto statement to netlink_insert
To: Stefan Priebe - Profihost AG <s.priebe@xxxxxxxxxxxx>
Cc: Hannes Frederic Sowa <hannes@xxxxxxxxxxxxxxxxxxx>, Florian Weimer <fweimer@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, jannik Winkel <j.winkel@xxxxxxxxxxxx>, Marco Schinkel <m.schinkel@xxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, stable@xxxxxxxxxxxxxxx
Message-ID: <20151208061319.GA16209@xxxxxxxxxxxxxxxxxxx>
Content-Disposition: inline
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
The backport of 1f770c0a09da855a2b51af6d19de97fb955eca85 ("netlink:
Fix autobind race condition that leads to zero port ID") missed a
goto statement, which causes netlink to break subtly.
This was discovered by Stefan Priebe <s.priebe@xxxxxxxxxxxx>.
Fixes: 4e2776241766 ("netlink: Fix autobind race condition that...")
Reported-by: Stefan Priebe <s.priebe@xxxxxxxxxxxx>
Reported-by: Philipp Hahn <pmhahn@xxxxxxxxx>
Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
net/netlink/af_netlink.c | 1 +
1 file changed, 1 insertion(+)
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -1118,6 +1118,7 @@ static int netlink_insert(struct sock *s
if (err == -EEXIST)
err = -EADDRINUSE;
sock_put(sk);
+ goto err;
}
/* We need to ensure that the socket is hashed and visible. */
Patches currently in stable-queue which might be from herbert@xxxxxxxxxxxxxxxxxxx are
queue-4.1/netlink-add-missing-goto-statement-to-netlink_insert.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html