Re: [PATCH v2] rtlwifi: fix memory leak for USB device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/06/2015 06:07 PM, Peter Wu wrote:
Free skb for received frames with a wrong checksum. This can happen
pretty rapidly, exhausting all memory.

This fixes a memleak (detected with kmemleak). Originally found while
using monitor mode, but it also appears during managed mode (once the
link is up).

Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Peter Wu <peter@xxxxxxxxxxxxx>
---
  v2: updated commit message based on Larry's feedback
  v1: https://lkml.kernel.org/r/1449424677-3140-1-git-send-email-peter@xxxxxxxxxxxxx

Tested with v4.3, rebased on v4.4-rc3 (changed paths). The bug goes back
to its introduction in the v2.6.x kernel.
---
  drivers/net/wireless/realtek/rtlwifi/usb.c | 2 ++
  1 file changed, 2 insertions(+)

ACKed-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>

Thanks,

Larry


diff --git a/drivers/net/wireless/realtek/rtlwifi/usb.c b/drivers/net/wireless/realtek/rtlwifi/usb.c
index 2721cf8..aac1ed3 100644
--- a/drivers/net/wireless/realtek/rtlwifi/usb.c
+++ b/drivers/net/wireless/realtek/rtlwifi/usb.c
@@ -531,6 +531,8 @@ static void _rtl_usb_rx_process_noagg(struct ieee80211_hw *hw,
  			ieee80211_rx(hw, skb);
  		else
  			dev_kfree_skb_any(skb);
+	} else {
+		dev_kfree_skb_any(skb);
  	}
  }



--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]