Re: [PATCH for 3.10-stable] virtio-net: drop NETIF_F_FRAGLIST

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/06/2015, 07:55 PM, Greg KH wrote:
> On Tue, Oct 27, 2015 at 01:50:53AM +0000, Sheng Yong wrote:
>> From: Jason Wang <jasowang@xxxxxxxxxx>
>>
>> commit 48900cb6af4282fa0fb6ff4d72a81aa3dadb5c39 upstream.
>>
>> virtio declares support for NETIF_F_FRAGLIST, but assumes
>> that there are at most MAX_SKB_FRAGS + 2 fragments which isn't
>> always true with a fraglist.
>>
>> A longer fraglist in the skb will make the call to skb_to_sgvec overflow
>> the sg array, leading to memory corruption.
>>
>> Drop NETIF_F_FRAGLIST so we only get what we can handle.
>>
>> Cc: Michael S. Tsirkin <mst@xxxxxxxxxx>
>> Signed-off-by: Jason Wang <jasowang@xxxxxxxxxx>
>> Acked-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
>> Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
>> ---
>>  drivers/net/virtio_net.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> This patch isn't in any stable tree, why just add it to 3.10?  What
> about all of the other ones?

This was now submitted by David in NETWORKING patches for >= 3.18. So I
applied it to 3.12.

thanks,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]