Re: [PATCH] USB: serial: fix TIOCMIWAIT return value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 05, 2013 at 10:19:20AM -0700, Greg KH wrote:
> On Wed, Jun 05, 2013 at 10:16:47AM -0700, Greg Kroah-Hartman wrote:
> > On Wed, Jun 05, 2013 at 10:12:19AM -0700, Greg Kroah-Hartman wrote:
> > > On Wed, Jun 05, 2013 at 05:44:44PM +0200, Johan Hovold wrote:
> > > > On Wed, Jun 05, 2013 at 08:33:56AM -0700, Greg KH wrote:
> > > > > On Wed, Jun 05, 2013 at 12:21:11PM +0200, Johan Hovold wrote:
> > > > > > Fix regression introduced by commit 143d9d9616 ("USB: serial: add
> > > > > > tiocmiwait subdriver operation") which made the ioctl operation return
> > > > > > ENODEV rather than ENOIOCTLCMD when a subdriver TIOCMIWAIT
> > > > > > implementation is missing.
> > > > > 
> > > > > Ah, maybe this is the problem I've been trying to track down, I'll queue
> > > > > it up and test it out now, thanks.
> > > > 
> > > > What problem would that be? Let me know if it helps.
> > > 
> > > Hm, no, I think we have bigger problems here.  Can you use more than one
> > > usb-serial device in the system right now on 3.10-rc4, with your
> > > patches?  I plug in a 4 port edgeport device, and a 1 port pl2303
> > > device, and no matter what /dev/ node I access (ttyUSB0-USB4), all the
> > > data is sent to the port assigned to /dev/ttyUSB0.
> > > 
> > > I think I have all of my changes backed out of my kernel, that I have
> > > been messing with in this area, but it would be good to get verification
> > > from someone else right now, as I've been working on this for a few
> > > hours now...
> > 
> > Ok, I can duplicate this with a 3.9.4 kernel from openSUSE, so something
> > has been broken for a while now.
> > 
> > Time to start bisecting...
> 
> Ugh, it's a broken test script.  Nevermind, it's one of those weeks it
> seems...

Hehe. Good to hear. ;)

Johan
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]