On Fri, Oct 02, 2015 at 07:47:24PM +0000, John Youn wrote: > On 10/1/2015 8:09 PM, John Youn wrote: > > On 10/1/2015 7:03 PM, Felipe Balbi wrote: > >> Hi, > >> > >> On Fri, Sep 04, 2015 at 07:15:10PM -0700, John Youn wrote: > >>> + > >>> +/* DWC_usb31 revisions */ > >>> +#define DWC3_USB31_REVISION_110A 0x3131302a > >> > >> are you sure you tested this ? Above you check for 0x33310000 but here you use > >> 0x3131 ? What gives ? Also, it seems odd that revision 1.10a is actually 3.02a > >> in HW, is this really correct ? > >> > > > > The one in the source file is wrong. I did run it but not sure > > how it was working... maybe wrong bitfile. I'll look into it > > and fix it. > > > > The version value is actually ASCII using all 4 > > bytes: "110*". The last 'a' is replaced with '*' in the register > > as that indicates a documentation only change with no IP changes. > > > > Correcting myself, the source is right the first time. > > The reason we check for "3331" in probe is because the 3.1 > core uses GSNPSID strictly as an ID register not a version. > > 3.0 IP: > GSNPSID = 0x5533 (ID) + 0x260a (VERSION) > > 3.1 IP: > GSNPSID = "33313130" (ID) > VER_NUMBER = "3131302a" (VERSION) oh all right, thanks for clarifying. :-) -- balbi
Attachment:
signature.asc
Description: PGP signature