On Mon, Sep 28, 2015 at 06:36:33PM +0100, Chen, Yu C wrote: > Hi, Javi > > > -----Original Message----- > > From: Javi Merino [mailto:javi.merino@xxxxxxx] > > Sent: Monday, September 28, 2015 10:29 PM > > To: Chen, Yu C > > Cc: linux-pm@xxxxxxxxxxxxxxx; edubezval@xxxxxxxxx; Zhang, Rui; linux- > > kernel@xxxxxxxxxxxxxxx; stable@xxxxxxxxxxxxxxx > > Subject: Re: [PATCH 2/3] Thermal: handle thermal zone device properly > > during system sleep > > > > On Sun, Sep 27, 2015 at 06:48:35AM +0100, Chen Yu wrote: > > > From: Zhang Rui <rui.zhang@xxxxxxxxx> > > > > > > > > > + register_pm_notifier(&thermal_pm_nb); > > > > What if register_pm_notifier() fails? It can't fail now, but that may in the > > future. If we fail to register thermal when we can't register the genetlink > > family, maybe we should also fail to register thermal if we fail to register the > > pm notifier, don't you think? > > > This pm notifier is mainly used for suspending situation, but it's not so 'critical' > to terminate the initialization of thermal core if it failed, IMO. In that case, just print a warning. Cheers, Javi > Hi, Rui, what do you think? Thx > > Best Regards, > Yu -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html