Hi,
On 2015년 09월 21일 20:29, Hans de Goede wrote:
> Hi,
>
> On 21-09-15 03:36, Chanwoo Choi wrote:
>> On 2015년 09월 20일 21:34, Hans de Goede wrote:
>>> is_extcon_changed should only check the idx-th bit of new, not
>>> the entirety of new when setting attached.
>>>
>>> This fixes extcon sending notifications that a cable was inserted when
>>> it gets removed while another cable is still connected.
>>>
>>> Cc: stable@xxxxxxxxxxxxxxx
>>> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
>>> ---
>>> drivers/extcon/extcon.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
>>> index a07addd..8dd0af1 100644
>>> --- a/drivers/extcon/extcon.c
>>> +++ b/drivers/extcon/extcon.c
>>> @@ -159,7 +159,7 @@ static int find_cable_index_by_name(struct extcon_dev *edev, const char *name)
>>> static bool is_extcon_changed(u32 prev, u32 new, int idx, bool *attached)
>>> {
>>> if (((prev >> idx) & 0x1) != ((new >> idx) & 0x1)) {
>>> - *attached = new ? true : false;
>>> + *attached = ((new >> idx) & 0x1) ? true : false;
>>> return true;
>>> }
>>>
>>>
>>
>> This patch was already applied[1].
>> [1] https://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/log/?h=extcon-next
>
> Yet it is not in 4.3-rc1, applying the patch to your tree is not useful
> unless you also send a pull-req to get the changes in your tree actually
> merged ...
No. It is useful step. It is first step to send pull-request for including the main tree.
I'll send pull-request before releasing official version.
Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html