On Sun, Sep 20, 2015 at 06:40:15PM -0700, Greg Kroah-Hartman wrote:
> On Sun, Sep 13, 2015 at 11:33:51AM +0530, Sudip Mukherjee wrote:
> > commit 9e326f78713a4421fe11afc2ddeac07698fac131 upstream
<snip>
> > Cc: <stable@xxxxxxxxxxxxxxx> # 3.14.x
> > Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx>
> > ---
> >
> > backporting for the first time so not exactly sure if the format is ok.
>
> You need to keep the original authorship of the patch around, as well as
> their signed-off-by information. Also, you didn't backport it
> identically:
>
<snip>
> > +
> > + if (!p) {
> > + err = -EINVAL;
> > + goto out_unlock;
>
> The original has a blank line between these two lines, why not keep it?
>
> I'll fix it up, but be a bit more careful next time please.
Sure, next time you will have no complaints about this.
regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html