On 16/09/15 11:37, Ian Abbott wrote:
commit abe46b8932dd9a6dfc3698e3eb121809b7b9ed28 upstream
Reading of analog input channels by the `INSN_READ` comedi instruction
is broken for all except channel 0. `pci171x_insn_read_ai()` calls
`pci171x_ai_dropout()` with the wrong value for the third parameter. It
is supposed to be the current index in a channel list (which is always
of length 1 in this case, so the index should be 0), but instead it is
passing the actual channel number. `pci171x_ai_dropout()` checks the
channel number encoded in the raw sample value read from the hardware
matches the channel number stored in the specified index of the
previously set up channel list and returns `-ENODATA` if it doesn't
match. Since the index should always be 0 in this case, the match will
fail unless the channel number is also 0. Fix it by passing 0 as the
channel index.
Fixes: 16c7eb6047bb ("staging: comedi: adv_pci1710: always enable PCI171x_PARANOIDCHECK code")
Signed-off-by: Ian Abbott <abbotti@xxxxxxxxx>
Oops. Please disregard this patch as it's already been applied (commit
ced9df8d7f9957e9b04e8080e0cd847f4e84f12f in linux-stable). Sorry for my
mistake.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html