Re: [PATCHES] Networking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Luis Henriques <luis.henriques@xxxxxxxxxxxxx>
Date: Thu, 27 Aug 2015 14:35:57 +0100

> Hi David,
> 
> On Wed, Aug 26, 2015 at 11:05:12PM -0700, David Miller wrote:
>> 
>> Please queue up the following networking bug fixes for v3.12, v3.14, v3.18,
>> and v4.1 -stable, respectively.
>> 
>> Thanks!
> 
> While going through these patches to pick those applicable to the 3.16
> kernel, I believe I found an issue with the backport of 1c1bf34951e8
> ("net/mlx4_core: Fix wrong index in propagating port change event to
> VFs") into 3.14.
> 
> The 2nd hunk has the following:
> 
> @@ -583,7 +583,7 @@ static int mlx4_eq_int(struct mlx4_dev *dev, struct mlx4_eq *eq)
>  					for (i = 0; i < dev->num_slaves; i++) {
>  						if (i == mlx4_master_func_num(dev))
>  							continue;
> -						s_info = &priv->mfunc.master.vf_oper[slave].vport[port].state;
> +						s_info = &priv->mfunc.master.vf_oper[slave].vport[i].state;
> 
> It should be:
> 
> -						s_info = &priv->mfunc.master.vf_oper[slave].vport[port].state;
> +						s_info = &priv->mfunc.master.vf_oper[i].vport[port].state;
> 
> (the 'slave' index should be changed by 'i', not 'port').

Sorry, you are definitely correct.  I hope the v3.14 -stable maintain
catches this, thanks!
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]