Re: [PATCH stable/3.18.y] media: remove unused variable that causes a warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sasha Levin <sasha.levin@xxxxxxxxxx> writes:

> On 08/24/2015 02:02 PM, Kevin Hilman wrote:
>> From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
>> 
>> My 'allmodconfig' build is _almost_ free of warnings, and most of the
>> remaining ones are for legacy drivers that just do bad things that I
>> can't find it in my black heart to care too much about.  But this one
>> was just annoying me:
>> 
>>    drivers/media/v4l2-core/videobuf2-core.c:3256:26: warning: unused variable ‘fileio’ [-Wunused-variable]
>> 
>> because commit 0e661006370b ("[media] vb2: fix 'UNBALANCED' warnings
>> when calling vb2_thread_stop()") removed all users of 'fileio' and
>> instead calls "__vb2_cleanup_fileio(q)" to clean up q->fileio.  But the
>> now unused 'fileio' variable was left around.
>> 
>> Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
>> (cherry picked from commit 1d11437f4fd02f9b5d3749675a1232216787dcc6)
>> Cc: <stable@xxxxxxxxxxxxxxx> # v3.18+
>> Signed-off-by: Kevin Hilman <khilman@xxxxxxxxxx>
>
> Hey Kevin,
>
> I'm afraid this isn't -stable material: it doesn't fix and actual problem
> that bothers users, so I can't take it.

OK, no worries.  I wasn't clear if trival build fixes qualified. 

Thanks,

Kevin
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]