On 08/14/2015, 10:48 AM, Jiri Slaby wrote: > On 08/13/2015, 10:08 PM, Nicholas A. Bellinger wrote: >> From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx> > > commit e54198657b65625085834847ab6271087323ffea upstream. > > I guess. Could you confirm? > >> This patch fixes a regression introduced with the following commit >> in v4.0-rc1 code, where a iscsit_start_kthreads() failure triggers >> a NULL pointer dereference OOPs: >> >> commit 88dcd2dab5c23b1c9cfc396246d8f476c872f0ca >> Author: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx> >> Date: Thu Feb 26 22:19:15 2015 -0800 >> >> iscsi-target: Convert iscsi_thread_set usage to kthread.h >> >> To address this bug, move iscsit_start_kthreads() immediately >> preceeding the transmit of last login response, before signaling >> a successful transition into full-feature-phase within existing >> iscsi_target_do_tx_login_io() logic. >> >> This ensures that no target-side resource allocation failures can >> occur after the final login response has been successfully sent. >> >> Also, it adds a iscsi_conn->rx_login_comp to allow the RX thread >> to sleep to prevent other socket related failures until the final >> iscsi_post_login_handler() call is able to complete. >> >> Issue DAT-3610 >> >> Change-Id: Ie41cd45dba698d4984ca711a56e4ffd3bb32ca6d > > What are these? There is nothing like that in e54198657b65 proper. Ok, I see now the same in the 3.10 thread :). -- js suse labs -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html