On Wed, 2015-08-12 at 13:55 +0300, Mathias Nyman wrote: > Fortunately this can only happen in cases where xhci is already hosed > (no command response for 5 seconds), and we are at the same time > anyway about to remove xhci. > > Doesn't this mean that all cases with > if (timer_pending(&timer)) > del_timer_sync(&timer) > > is just basically the same as a plain del_timer(&timer)? Yes. I never understood the idiom. > Anyways, turns out that the error path in xhci initialization code can end up calling > del_timer_sync() before timer is initialized. This should be fixed by re-arranging > some code in xhci initialization instead. Good. > Greg, should this be reverted in rc7? > I think that the possible side effect of this patch is still lesser the original > issue. I agree. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html