Hello.
On 05/25/2013 01:54 AM, Sarah Sharp wrote:
From: "Chew, Chiau Ee" <chiau.ee.chew@xxxxxxxxx>
Like the xHCI controller on Intel Panther Point and Lynx Point
chipsets, the xHCI controller on Intel BayTrail has also ports that
can be switched between the EHCI host controller.
s/between/to/
Sergei, DO NOT REVIEW PATCHES TO THE XHCI DRIVER.
OK, I'll try to follow another rule from you, though I'm getting
tired of you telling me what not to do.
I've told you not to review patches to the xHCI driver three times now.
This is not "another rule", this is something I've asked you to avoid
already.
Strange, I would have remembered if you told me *thrice*, yet what I
clearly
remember you told me is not to comment on your own patches.
I've been asking you to change how you review your patches because you
can't seem to pick up on the social cues that nitpicking patches about
only grammar and random code style issues is not constructive. You
don't seem to be getting the hint, hence the ALL CAPS and blunt words.
Maybe because you are the only one (plus maybe Greg) having issues
with my reviews. I've never been harassed for my review style on any other
mailing lists I'm subscribed to. Usually people are even grateful for
whatever
review is provided.
Your grammar comments and complaints about extra parenthesis are not
constructive and cause unnecessary patch churn.
As if I haven't ever found more serious issues in your own XHCI patches
(even after you forbade me to review them).
Serious issues are fine to bring up, either for my patches or for
patches that people send for the xHCI. However, the vast majority of
comments I see from you are simply grammar comments or nitpicking of
code style that checkpatch.pl doesn't complain about.
checkpatch.pl unfortunately is not perfect, there's CodingStyle
violations
it doesn't complain about. And not everybody even runs checkpatch.pl
unfortunately
(I myself often forget that).
At some point, your signal to noise ratio is so low that most kernel
developers are just going to start tuning you out.
As I said, so far I had serious issues due to my reviews only with
one or two people
in the past several years. I started appearing on the Linux mailing
lists since 2004.
Greg already put
your email into /dev/null. Do you want other kernel developers to do so
as well?
I remember Greg has commented to my patches not so long ago.
Maybe he did put me into his killfile recently but I don't know what
accident
might have triggered that.
If you want *serious bugs* to be acted on, then just send email about
*serious bugs*. Or include a mix of comments about grammar/code style
in with comments about serious code issues.
Fortunately, serious issues are rare and unfortunately, it's harder
to see
them (in the xHCI driver particularly, as I'm not familiar with its code).
Please increase your signal to noise ratio, or I will continue to send
you scathing emails when you nitpick xHCI patches.
I've already consented not to review them (at least unless I see
something
serious enough).
Sarah Sharp
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html