RE: [PATCH v2 net 2/2] tg3: Fix data corruption on 5725 with TSO

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2013-05-15 at 09:56 +0100, David Laight wrote: 
> > > If the 'fix' is to relocate the skb you are doomed to lose regardless
> > > of the check - unless you are willing to reallocate a lot of times,
> > > and without freeing the old skb.
> > > I'd assumed the 'fix' was to disable the relevant offload.
> > 
> > We relocate once and then drop the packet if we encounter additional
> > errors, including OOM, DMA mapping error, 4G boundary, etc.  The new
> > linear skb should not hit the 4G boundary again.  The room between the
> > end of this current buffer and 4G isn't big enough for the new linear
> > skb.
> 
> The first skb might be just below the 4G boundary and the
> second just below the 8G one.
> 

We will discard the packet if that happens.  I think the probabilty is
very small.


--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]