Re: [PATCH v3.2] tracing: Fix ftrace_dump()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2013-05-10 at 04:59 +0100, Ben Hutchings wrote:
> On Fri, 2013-05-03 at 20:25 -0400, Steven Rostedt wrote:
> > ftrace_dump() had a lot of issues. What ftrace_dump() does, is when
> > ftrace_dump_on_oops is set (via a kernel parameter or sysctl), it
> > will dump out the ftrace buffers to the console when either a oops,
> > panic, or a sysrq-z occurs.
> 
> Queued up for 3.2, thanks.
> 
> [...]
> > --- a/kernel/trace/trace.c
> > +++ b/kernel/trace/trace.c
> [...]
> > -
> > -/* By default: disable tracing after the dump */
> > -void ftrace_dump(enum ftrace_dump_mode oops_dump_mode)
> > -{
> > -	__ftrace_dump(true, oops_dump_mode);
> > -}
> > +EXPORT_SYMBOL_GPL(ftrace_dump);
> [...]
> 
> I don't think this addition was needed, though.
> 

Up to you. That was suppose to have been there from day one. As I had
patches to add ftrace_dump to WARN_ON() as well. Not sure why I didn't
add the export then.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]