This is a note to let you know that I've just added the patch titled
ipv6/tcp: Stop processing ICMPv6 redirect messages
to the 3.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ipv6-tcp-stop-processing-icmpv6-redirect-messages.patch
and it can be found in the queue-3.8 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 1dbb428feb7eb340bd16cb06b90d218a4cf13e62 Mon Sep 17 00:00:00 2001
From: Christoph Paasch <christoph.paasch@xxxxxxxxxxxx>
Date: Sun, 7 Apr 2013 04:53:15 +0000
Subject: ipv6/tcp: Stop processing ICMPv6 redirect messages
From: Christoph Paasch <christoph.paasch@xxxxxxxxxxxx>
[ Upstream commit 50a75a8914539c5dcd441c5f54d237a666a426fd ]
Tetja Rediske found that if the host receives an ICMPv6 redirect message
after sending a SYN+ACK, the connection will be reset.
He bisected it down to 093d04d (ipv6: Change skb->data before using
icmpv6_notify() to propagate redirect), but the origin of the bug comes
from ec18d9a26 (ipv6: Add redirect support to all protocol icmp error
handlers.). The bug simply did not trigger prior to 093d04d, because
skb->data did not point to the inner IP header and thus icmpv6_notify
did not call the correct err_handler.
This patch adds the missing "goto out;" in tcp_v6_err. After receiving
an ICMPv6 Redirect, we should not continue processing the ICMP in
tcp_v6_err, as this may trigger the removal of request-socks or setting
sk_err(_soft).
Reported-by: Tetja Rediske <tetja@xxxxxxxx>
Signed-off-by: Christoph Paasch <christoph.paasch@xxxxxxxxxxxx>
Acked-by: Eric Dumazet <edumazet@xxxxxxxxxx>
Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
net/ipv6/tcp_ipv6.c | 1 +
1 file changed, 1 insertion(+)
--- a/net/ipv6/tcp_ipv6.c
+++ b/net/ipv6/tcp_ipv6.c
@@ -386,6 +386,7 @@ static void tcp_v6_err(struct sk_buff *s
if (dst)
dst->ops->redirect(dst, sk, skb);
+ goto out;
}
if (type == ICMPV6_PKT_TOOBIG) {
Patches currently in stable-queue which might be from christoph.paasch@xxxxxxxxxxxx are
queue-3.8/ipv6-tcp-stop-processing-icmpv6-redirect-messages.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html