[PATCH 0/2] v2.6.34.14: Fix Build Warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: "George G. Davis" <george_davis@xxxxxxxxxx>

The following v2.6.34.14 commits introduced build warnings which did
not exist in v2.6.34.13:

d7542a6 udf: Avoid run away loop when partition table length is corrupted
3f52a40 percpu: fix first chunk match in per_cpu_ptr_to_phys()

Commit d7542a6 introduced the following build warnings due to the omission
of a required argument when backporting an upstream fix to v2.6.34.14:

  CC      fs/udf/super.o
/home/gdavis/linux-2.6/fs/udf/super.c: In function ‘udf_load_sparable_map’:
/home/gdavis/linux-2.6/fs/udf/super.c:1259:6: warning: passing argument 3 of ‘udf_error’ makes pointer from integer without a cast [enabled by default]
/home/gdavis/linux-2.6/fs/udf/super.c:97:13: note: expected ‘const char *’ but argument is of type ‘unsigned int’
/home/gdavis/linux-2.6/fs/udf/super.c:1265:6: warning: passing argument 3 of ‘udf_error’ makes pointer from integer without a cast [enabled by default]
/home/gdavis/linux-2.6/fs/udf/super.c:97:13: note: expected ‘const char *’ but argument is of type ‘int’
/home/gdavis/linux-2.6/fs/udf/super.c: In function ‘udf_load_logicalvol’:
/home/gdavis/linux-2.6/fs/udf/super.c:1313:6: warning: passing argument 3 of ‘udf_error’ makes pointer from integer without a cast [enabled by default]
/home/gdavis/linux-2.6/fs/udf/super.c:97:13: note: expected ‘const char *’ but argument is of type ‘unsigned int’

Commit 3f52a40 introduced the following build warning due to a missing
dependency on upstream commit "020ec65 percpu: factor out
pcpu_addr_in_first/reserved_chunk() and update per_cpu_ptr_to_phys()":

  CC      mm/percpu.o
/home/gdavis/linux-2.6/mm/percpu.c: In function ‘per_cpu_ptr_to_phys’:
/home/gdavis/linux-2.6/mm/percpu.c:1377:1: warning: control reaches end of non-void function [-Wreturn-type]

The above build warnings will likely result in kernel oopses when the
above lines are executed.

The first issue is fixed by adding the missing argument in udf_error
functions calls.

The second issue is resolved by backporting "020ec65 percpu: factor out
pcpu_addr_in_first/reserved_chunk() and update per_cpu_ptr_to_phys()"
to add the missing (else clause) dependency.

Please apply to linux-2.6.34.y.

TIA!

--

George G. Davis (1):
  udf: fix udf_error build warnings

Tejun Heo (1):
  percpu: factor out pcpu_addr_in_first/reserved_chunk() and update
    per_cpu_ptr_to_phys()

 fs/udf/super.c |  9 ++++++---
 mm/percpu.c    | 25 ++++++++++++++++++++-----
 2 files changed, 26 insertions(+), 8 deletions(-)

-- 
1.7.11.7

--
Regards,
George
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]