Re: [PATCH v7 0/6] usb: chipidea: udc: bugfixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/27/2013 05:37 PM, Marc Kleine-Budde wrote:
> On 03/27/2013 05:35 PM, Alexander Shishkin wrote:
>> Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx> writes:
>>
>>> Hi,
>>>
>>> this series solve some issues with the chipidea udc.
>>>
>>> The series is based on v3.9-rc4.
>>>
>>> Michael Grzeschik (6):
>>>   usb: chipidea: udc: add attribute aligned(4) to shared memory structs
>>>   usb: chipidea: udc: only clear active and halted bits in qhead
>>>   usb: chipidea: udc: move ZLT flag change to ep_enable
>>>   usb: chipidea: udc: read status of td only once in hardware_dequeue
>>>   usb: chipidea: udc: don't truncate requests to single tds
>>>   usb: chipidea: udc: move _ep_queue into an unlocked function
>>
>> Actually, do any of these patches fix tangible bugs, that can be
>> reproduced? If so, you should certainly mention that. But somehow I doubt
>> that, because otherwise the driver will be totally unusable.
>>
>> What I see is patches that bring some parts of udc code in accordance
>> with the spec, which is a good thing to do, but doesn't fix any "real
>> bugs that bother people". Or does it?
> 
> Patch 1/7 is essential to make the udc stable on armv5, should be added
> to the patch description, though.

I mean 1/6.

"usb: chipidea: udc: add attribute aligned(4) to shared memory structs"

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]