[CC'ing stable & Willy - for the older releases not fed by http://patchwork.ozlabs.org/bundle/davem/stable/ ] On Tue, Mar 5, 2013 at 12:15 PM, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote: > From: Eric Dumazet <edumazt@xxxxxxxxxx> > > We should use time_after_eq() to get maximum latency of two ticks, > instead of three. > > Bug added in commit 24f8b2385 (net: increase receive packet quantum) I'm not sure what applications would notice the extra tick, but 24f8b takes us back to 2.6.29. It cherry picks cleanly onto 2.6.34, so it probably also does the same for Willy's 2.6.32 longterm too. Commit is now mainline d114a3338747255518 - v3.9-rc3~36^2~34. Paul. -- > > Signed-off-by: Eric Dumazet <edumazt@xxxxxxxxxx> > --- > net/core/dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/core/dev.c b/net/core/dev.c > index 18d8b5a..461b315 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -4107,7 +4107,7 @@ static void net_rx_action(struct softirq_action *h) > * Allow this to run for 2 jiffies since which will allow > * an average latency of 1.5/HZ. > */ > - if (unlikely(budget <= 0 || time_after(jiffies, time_limit))) > + if (unlikely(budget <= 0 || time_after_eq(jiffies, time_limit))) > goto softnet_break; > > local_irq_enable(); > > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html