On Wed, Mar 20, 2013 at 05:07:28PM +0100, Oleg Nesterov wrote: > On 03/20, Ananth N Mavinakayanahalli wrote: > > > > On Wed, Mar 20, 2013 at 01:43:01PM +0100, Oleg Nesterov wrote: > > > On 03/20, Oleg Nesterov wrote: > > > > > > > > But we did not install UPROBE_SWBP_INSN. Is it fine? I hope yes, just to > > > > verify. If not, we need 2 definitions. is_uprobe_insn() should still check > > > > insns == UPROBE_SWBP_INSN, and is_swbp_insn() should check is_trap(). > > > > > > > > And I am just curious, could you explain how X and UPROBE_SWBP_INSN > > > > differ? > > > > > > IOW, if I wasn't clear... Lets forget about gdb/etc for the moment. > > > Suppose we apply the patch below. Will uprobes on powerpc work? > > > > > > If yes, then your patch should be fine. If not, we probably need more > > > changes. > > > > Yes, it will work fine. > > Even if this new insn is conditional? Yes. -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html