Re: [PATCH] drm/i915: EBUSY status handling added to i915_gem_fault().

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 18, 2013 at 04:17:31PM +0000, Chris Wilson wrote:
> On Mon, Mar 18, 2013 at 09:02:57AM -0700, Greg KH wrote:
> > On Mon, Mar 18, 2013 at 10:22:19AM +0000, Chris Wilson wrote:
> > > From: Dmitry Rogozhkin <dmitry.v.rogozhkin@xxxxxxxxx>
> > > 
> > > commit e79e0fe380847493266fba557217e2773c61bd1b upstream.
> > > 
> > > Subsequent threads returning EBUSY from vm_insert_pfn() was not handled
> > > correctly. As a result concurrent access from new threads to
> > > mmapped data caused SIGBUS.
> > > 
> > > Note that this fixes i-g-t/tests/gem_threaded_tiled_access.
> > > 
> > > Tested-by: Mika Kuoppala <mika.kuoppala@xxxxxxxxx>
> > > Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@xxxxxxxxx>
> > > Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
> > > ---
> > >  drivers/gpu/drm/i915/i915_gem.c |    5 +++++
> > >  1 file changed, 5 insertions(+)
> > 
> > What stable release(s) should this be applied to?
> 
> The vulnerability exists right from the initial import of GEM, v2.6.29.
> It is only recently that userspace has become adventurous enough to hit
> the race condition.

But, as this patch showed up originally in 3.7, it will not apply to
3.8, so it might have been nice to mention that before it caused me some
confusion as to why it wouldn't apply properly to that tree :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]