Re: [PATCH] loopdev: remove an user triggerable oops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2013-03-15 at 18:24 -0400, Jeff Mahoney wrote:
> Commit b1a6650406875b9097a032eed89af50682fe1160 upstream.
> 
> When loopdev is built as module and we pass an invalid parameter,
> loop_init() will return directly without deregister misc device, which
> will cause an oops when insert loop module next time because we left some
> garbage in the misc device list.
> 
> Test case:
> sudo modprobe loop max_part=1024
> (failed due to invalid parameter)
> sudo modprobe loop
> (oops)
> 
> Clean up nicely to avoid such oops.
> 
> Signed-off-by: Guo Chao <yan@xxxxxxxxxxxxxxxxxx>
> Cc: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>
> Cc: Guo Chao <yan@xxxxxxxxxxxxxxxxxx>
> Cc: M. Hindess <hindessm@xxxxxxxxxx>
> Cc: Nikanth Karthikesan <knikanth@xxxxxxx>
> Cc: Jens Axboe <axboe@xxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx # 3.2 3.4 3.8
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>
> Acked-by: Jeff Mahoney <jeffm@xxxxxxxx>
[...]

Queued up for 3.2, thanks.

Ben.

-- 
Ben Hutchings
Never attribute to conspiracy what can adequately be explained by stupidity.

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]