On Wed, 2013-03-13 at 10:17 +1100, Michael Neuling wrote: > Thadeu Lima de Souza Cascardo <cascardo@xxxxxxxxxxxxxxxxxx> wrote: > > > On Fri, Mar 08, 2013 at 03:29:55AM +0000, Ben Hutchings wrote: > > > On Fri, 2013-03-08 at 13:51 +1100, Michael Neuling wrote: > > > > This patch is breaking the celleb_defconfig on powerpc with: > > > > > > > > arch/powerpc/kernel/of_platform.c: In function 'of_pci_phb_probe': > > > > arch/powerpc/kernel/of_platform.c:95:2: error: implicit declaration of > > > > function 'eeh_add_sysfs_files' [-Werror=implicit-function-declaration] > > > > > > In 3.2 this file doesn't (directly) include <asm/eeh.h> which is where > > > the definition was added. In mainline it does. > > > > > > Assuming that this change is actually required for 3.2 (which I'm not > > > sure about), I suppose we just need to add the #include. > > > > > > Ben. > > > > > > > This is not required for 3.2. The patch that *may* have broken DLPAR > > (39baadbf36cee3ede5fdb8a34006d9109e5e2570) was introduced between 3.3 > > and 3.4. > > Reverting 066f289835f09a3f744d6bac96f25e25d20b3ded (from 3.2.40) fixes > the problem for me so I'm ok if we do that instead. Thanks all; I've queued up the revert. Ben. -- Ben Hutchings Humans are not rational beings; they are rationalising beings.
Attachment:
signature.asc
Description: This is a digitally signed message part