Re: [PATCH] drm/i915: enable irqs earlier when resuming

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 05, 2013 at 09:50:58AM +0100, Daniel Vetter wrote:
> We need it to restore the ilk rc6 context, since the gpu wait no
> requires interrupts. But in general having interrupts around should
> help in code sanity, since more and more stuff is interrupt driven.
> 
> This regression has been introduced in
> 
> commit 3e9605018ab3e333d51cc90fccfde2031886763b
> Author: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Date:   Tue Nov 27 16:22:54 2012 +0000
> 
>     drm/i915: Rearrange code to only have a single method for waiting upon the ring

Not entirely, as we can also regard this as an oversight from fixing up
the irq sequence during initialisation... :-p
> 
> Like in the driver load code we need to make sure that hotplug
> interrupts don't cause havoc with our modeset state, hence block them
> with the existing infrastructure. Again we ignore races where we might
> loose hotplug interrupts ...
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=54691
> Cc: stable@xxxxxxxxxxxxxxx (for 3.8 only)
> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxx>
> Reported-and-Tested-by: Ilya Tumaykin <itumaykin@xxxxxxxxx>
> Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxx>

Reviewed-by: Chris wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]