Patch "smb: client: fix chmod(2) regression with ATTR_READONLY" has been added to the 6.6-stable tree

[Sasha Levin <sashal@xxxxxxxxxx>]

This is a note to let you know that I've just added the patch titled

    smb: client: fix chmod(2) regression with ATTR_READONLY

to the 6.6-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     smb-client-fix-chmod-2-regression-with-attr_readonly.patch
and it can be found in the queue-6.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 154e083ed7e08fd6dfe0536abdcf223519dd652a
Author: Paulo Alcantara <pc@xxxxxxxxxxxxx>
Date:   Sun Feb 16 18:02:47 2025 -0300

    smb: client: fix chmod(2) regression with ATTR_READONLY
    
    [ Upstream commit 654292a0b264e9b8c51b98394146218a21612aa1 ]
    
    When the user sets a file or directory as read-only (e.g. ~S_IWUGO),
    the client will set the ATTR_READONLY attribute by sending an
    SMB2_SET_INFO request to the server in cifs_setattr_{,nounix}(), but
    cifsInodeInfo::cifsAttrs will be left unchanged as the client will
    only update the new file attributes in the next call to
    {smb311_posix,cifs}_get_inode_info() with the new metadata filled in
    @data parameter.
    
    Commit a18280e7fdea ("smb: cilent: set reparse mount points as
    automounts") mistakenly removed the @data NULL check when calling
    is_inode_cache_good(), which broke the above case as the new
    ATTR_READONLY attribute would end up not being updated on files with a
    read lease.
    
    Fix this by updating the inode whenever we have cached metadata in
    @data parameter.
    
    Reported-by: Horst Reiterer <horst.reiterer@xxxxxxxxxxxx>
    Closes: https://lore.kernel.org/r/85a16504e09147a195ac0aac1c801280@xxxxxxxxxxxx
    Fixes: a18280e7fdea ("smb: cilent: set reparse mount points as automounts")
    Cc: stable@xxxxxxxxxxxxxxx
    Signed-off-by: Paulo Alcantara (Red Hat) <pc@xxxxxxxxxxxxx>
    Signed-off-by: Steve French <stfrench@xxxxxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/fs/smb/client/inode.c b/fs/smb/client/inode.c
index b3e59a7c71205..dbb407d5e6dab 100644
--- a/fs/smb/client/inode.c
+++ b/fs/smb/client/inode.c
@@ -1320,7 +1320,7 @@ int cifs_get_inode_info(struct inode **inode,
 	struct cifs_fattr fattr = {};
 	int rc;
 
-	if (is_inode_cache_good(*inode)) {
+	if (!data && is_inode_cache_good(*inode)) {
 		cifs_dbg(FYI, "No need to revalidate cached inode sizes\n");
 		return 0;
 	}
@@ -1419,7 +1419,7 @@ int smb311_posix_get_inode_info(struct inode **inode,
 	struct cifs_fattr fattr = {};
 	int rc;
 
-	if (is_inode_cache_good(*inode)) {
+	if (!data && is_inode_cache_good(*inode)) {
 		cifs_dbg(FYI, "No need to revalidate cached inode sizes\n");
 		return 0;
 	}