From: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxxxxxxxx>
commit 46c7b901e2a03536df5a3cb40b3b26e2be505df6 upstream.
The spcm->stream[substream->stream].substream is set during open and was
left untouched. After the first PCM stream it will never be NULL and we
have code which checks for substream NULLity as indication if the stream is
active or not.
For the compressed cstream pointer the same has been done, this change will
correct the handling of PCM streams.
Fixes: 090349a9feba ("ASoC: SOF: Add support for compress API for stream data/offset")
Cc: stable@xxxxxxxxxxxxxxx
Reported-by: Curtis Malainey <cujomalainey@xxxxxxxxxxxx>
Closes: https://github.com/thesofproject/linux/pull/5214
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxxxxxxxx>
Reviewed-by: Daniel Baluta <daniel.baluta@xxxxxxx>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@xxxxxxxxxxxxxxx>
Reviewed-by: Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx>
Reviewed-by: Curtis Malainey <cujomalainey@xxxxxxxxxxxx>
Link: https://patch.msgid.link/20250205135232.19762-3-peter.ujfalusi@xxxxxxxxxxxxxxx
Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
sound/soc/sof/pcm.c | 2 ++
1 file changed, 2 insertions(+)
--- a/sound/soc/sof/pcm.c
+++ b/sound/soc/sof/pcm.c
@@ -511,6 +511,8 @@ static int sof_pcm_close(struct snd_soc_
*/
}
+ spcm->stream[substream->stream].substream = NULL;
+
return 0;
}
Patches currently in stable-queue which might be from peter.ujfalusi@xxxxxxxxxxxxxxx are
queue-6.13/asoc-sof-pcm-clear-the-susbstream-pointer-to-null-on-close.patch
queue-6.13/asoc-sof-ipc4-topology-harden-loops-for-looking-up-a.patch
queue-6.13/asoc-sof-stream-ipc-check-for-cstream-nullity-in-sof_ipc_msg_data.patch
