From: Vicki Pfau <vi@xxxxxxxxxxx>
commit b051ffa2aeb2a60e092387b6fb2af1ad42f51a3c upstream.
Lockdep reported that, as steam_do_deck_input_event is called from
steam_raw_event inside of an IRQ context, it can lead to issues if that IRQ
occurs while the work to be cancelled is running. By using cancel_delayed_work,
this issue can be avoided. The exact ordering of the work and the event
processing is not super important, so this is safe.
Fixes: cd438e57dd05 ("HID: hid-steam: Add gamepad-only mode switched to by holding options")
Signed-off-by: Vicki Pfau <vi@xxxxxxxxxxx>
Signed-off-by: Jiri Kosina <jkosina@xxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/hid/hid-steam.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/hid/hid-steam.c
+++ b/drivers/hid/hid-steam.c
@@ -1615,7 +1615,7 @@ static void steam_do_deck_input_event(st
if (!(b9 & BIT(6)) && steam->did_mode_switch) {
steam->did_mode_switch = false;
- cancel_delayed_work_sync(&steam->mode_switch);
+ cancel_delayed_work(&steam->mode_switch);
} else if (!steam->client_opened && (b9 & BIT(6)) && !steam->did_mode_switch) {
steam->did_mode_switch = true;
schedule_delayed_work(&steam->mode_switch, 45 * HZ / 100);
Patches currently in stable-queue which might be from vi@xxxxxxxxxxx are
queue-6.6/hid-hid-steam-disable-watchdog-instead-of-using-a-he.patch
queue-6.6/hid-hid-steam-make-sure-rumble-work-is-canceled-on-r.patch
queue-6.6/hid-hid-steam-move-hidraw-input-un-registering-to-wo.patch
queue-6.6/hid-hid-steam-don-t-use-cancel_delayed_work_sync-in-irq-context.patch
queue-6.6/hid-hid-steam-update-list-of-identifiers-from-sdl.patch
queue-6.6/hid-hid-steam-clean-up-locking.patch
queue-6.6/hid-hid-steam-remove-pointless-error-message.patch
queue-6.6/hid-hid-steam-fix-cleanup-in-probe.patch
queue-6.6/hid-hid-steam-add-gamepad-only-mode-switched-to-by-h.patch
queue-6.6/hid-hid-steam-add-deck-imu-support.patch
queue-6.6/hid-hid-steam-avoid-overwriting-smoothing-parameter.patch
