Patch "pinctrl: pinconf-generic: Print unsigned value if a format is registered" has been added to the 6.13-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    pinctrl: pinconf-generic: Print unsigned value if a format is registered

to the 6.13-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     pinctrl-pinconf-generic-print-unsigned-value-if-a-fo.patch
and it can be found in the queue-6.13 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit dcae403e7650d4fffe4684ec3c4a7ddcc7710b60
Author: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
Date:   Wed Feb 5 12:10:58 2025 +0200

    pinctrl: pinconf-generic: Print unsigned value if a format is registered
    
    [ Upstream commit 0af4c120f5e7a1ea70aff7da2dfb65b6148a3e84 ]
    
    Commit 3ba11e684d16 ("pinctrl: pinconf-generic: print hex value")
    unconditionally switched to printing hex values in
    pinconf_generic_dump_one(). However, if a dump format is registered for the
    dumped pin, the hex value is printed as well. This hex value does not
    necessarily correspond 1:1 with the hardware register value (as noted by
    commit 3ba11e684d16 ("pinctrl: pinconf-generic: print hex value")). As a
    result, user-facing output may include information like:
    output drive strength (0x100 uA).
    
    To address this, check if a dump format is registered for the dumped
    property, and print the unsigned value instead when applicable.
    
    Fixes: 3ba11e684d16 ("pinctrl: pinconf-generic: print hex value")
    Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
    Link: https://lore.kernel.org/20250205101058.2034860-1-claudiu.beznea.uj@xxxxxxxxxxxxxx
    Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/pinctrl/pinconf-generic.c b/drivers/pinctrl/pinconf-generic.c
index 0b13d7f17b325..42547f64453e8 100644
--- a/drivers/pinctrl/pinconf-generic.c
+++ b/drivers/pinctrl/pinconf-generic.c
@@ -89,12 +89,12 @@ static void pinconf_generic_dump_one(struct pinctrl_dev *pctldev,
 		seq_puts(s, items[i].display);
 		/* Print unit if available */
 		if (items[i].has_arg) {
-			seq_printf(s, " (0x%x",
-				   pinconf_to_config_argument(config));
+			u32 val = pinconf_to_config_argument(config);
+
 			if (items[i].format)
-				seq_printf(s, " %s)", items[i].format);
+				seq_printf(s, " (%u %s)", val, items[i].format);
 			else
-				seq_puts(s, ")");
+				seq_printf(s, " (0x%x)", val);
 		}
 	}
 }




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux