x86/mm: Convert unreachable() to BUG()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>

commit 41a1e976623eb430f7b5a8619d3810b44e6235ad upstream.

Commit 2190966fbc14 ("x86: Convert unreachable() to BUG()") missed
one.

And after commit 06e24745985c ("objtool: Remove
annotate_{,un}reachable()") the invalid use of unreachable()
(rightfully) triggers warnings:

  vmlinux.o: warning: objtool: page_fault_oops() falls through to next function is_prefetch()

Fixes: 2190966fbc14 ("x86: Convert unreachable() to BUG()")
Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
Link: https://lkml.kernel.org/r/20241216093215.GD12338@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
 arch/x86/mm/fault.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/x86/mm/fault.c
+++ b/arch/x86/mm/fault.c
@@ -678,7 +678,7 @@ page_fault_oops(struct pt_regs *regs, un
 			      ASM_CALL_ARG3,
 			      , [arg1] "r" (regs), [arg2] "r" (address), [arg3] "r" (&info));
 
-		unreachable();
+		BUG();
 	}
 #endif
 


Patches currently in stable-queue which might be from peterz@xxxxxxxxxxxxx are

queue-6.12/sched-deadline-check-bandwidth-overflow-earlier-for-.patch
queue-6.12/sched-deadline-correctly-account-for-allocated-bandw.patch
queue-6.12/ring-buffer-do-not-allow-events-in-nmi-with-generic-atomic64-cmpxchg.patch
queue-6.12/lockdep-fix-upper-limit-for-lockdep_-_bits-configs.patch
queue-6.12/atomic64-use-arch_spin_locks-instead-of-raw_spin_locks.patch
queue-6.12/sched-don-t-try-to-catch-up-excess-steal-time.patch
queue-6.12/sched-fair-fix-inaccurate-h_nr_runnable-accounting-w.patch
queue-6.12/x86-mm-convert-unreachable-to-bug.patch
queue-6.12/x86-convert-unreachable-to-bug.patch
queue-6.12/rv-reset-per-task-monitors-also-for-idle-tasks.patch




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux