Patch "pinctrl: samsung: Fix irq handling if an error occurs in exynos_irq_demux_eint16_31()" has been added to the 6.12-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    pinctrl: samsung: Fix irq handling if an error occurs in exynos_irq_demux_eint16_31()

to the 6.12-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     pinctrl-samsung-fix-irq-handling-if-an-error-occurs-.patch
and it can be found in the queue-6.12 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit ebdc7585ff52c743de4ed191e10f271084991c6f
Author: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
Date:   Sun Nov 17 13:03:32 2024 +0100

    pinctrl: samsung: Fix irq handling if an error occurs in exynos_irq_demux_eint16_31()
    
    [ Upstream commit f686a2b52e9d78cf401f1b7f446bf0c3a81ebcc0 ]
    
    chained_irq_enter(() should be paired with a corresponding
    chained_irq_exit().
    
    Here, if clk_enable() fails, a early return occurs and chained_irq_exit()
    is not called.
    
    Add a new label and a goto for fix it.
    
    Fixes: f9c744747973 ("pinctrl: samsung: support a bus clock")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
    Reviewed-by: André Draszik <andre.draszik@xxxxxxxxxx>
    Link: https://lore.kernel.org/r/f148d823acfb3326a115bd49a0eed60f2345f909.1731844995.git.christophe.jaillet@xxxxxxxxxx
    Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c
index b79c211c03749..ac6dc22b37c98 100644
--- a/drivers/pinctrl/samsung/pinctrl-exynos.c
+++ b/drivers/pinctrl/samsung/pinctrl-exynos.c
@@ -636,7 +636,7 @@ static void exynos_irq_demux_eint16_31(struct irq_desc *desc)
 		if (clk_enable(b->drvdata->pclk)) {
 			dev_err(b->gpio_chip.parent,
 				"unable to enable clock for pending IRQs\n");
-			return;
+			goto out;
 		}
 	}
 
@@ -652,6 +652,7 @@ static void exynos_irq_demux_eint16_31(struct irq_desc *desc)
 	if (eintd->nr_banks)
 		clk_disable(eintd->banks[0]->drvdata->pclk);
 
+out:
 	chained_irq_exit(chip, desc);
 }
 




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux