Patch "PCI: endpoint: pci-epf-test: Fix check for DMA MEMCPY test" has been added to the 6.13-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    PCI: endpoint: pci-epf-test: Fix check for DMA MEMCPY test

to the 6.13-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     pci-endpoint-pci-epf-test-fix-check-for-dma-memcpy-t.patch
and it can be found in the queue-6.13 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit fd8a57b80e27f318f47051f9210934f5ab0f7eb1
Author: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
Date:   Thu Jan 16 22:46:47 2025 +0530

    PCI: endpoint: pci-epf-test: Fix check for DMA MEMCPY test
    
    [ Upstream commit 235c2b197a8de2887f13990094a3343d2392155b ]
    
    Currently, if DMA MEMCPY test is requested by the host, and if the endpoint
    DMA controller supports DMA_PRIVATE, the test will fail. This is not
    correct since there is no check for DMA_MEMCPY capability and the DMA
    controller can support both DMA_PRIVATE and DMA_MEMCPY.
    
    Fix the check and also reword the error message.
    
    Link: https://lore.kernel.org/r/20250116171650.33585-2-manivannan.sadhasivam@xxxxxxxxxx
    Fixes: 8353813c88ef ("PCI: endpoint: Enable DMA tests for endpoints with DMA capabilities")
    Reported-by: Niklas Cassel <cassel@xxxxxxxxxx>
    Closes: https://lore.kernel.org/linux-pci/Z3QtEihbiKIGogWA@ryzen
    Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
    Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
    Tested-by: Niklas Cassel <cassel@xxxxxxxxxx>
    Reviewed-by: Niklas Cassel <cassel@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
index d90c8be7371e0..b2fdd8c82c438 100644
--- a/drivers/pci/endpoint/functions/pci-epf-test.c
+++ b/drivers/pci/endpoint/functions/pci-epf-test.c
@@ -328,8 +328,8 @@ static void pci_epf_test_copy(struct pci_epf_test *epf_test,
 	void *copy_buf = NULL, *buf;
 
 	if (reg->flags & FLAG_USE_DMA) {
-		if (epf_test->dma_private) {
-			dev_err(dev, "Cannot transfer data using DMA\n");
+		if (!dma_has_cap(DMA_MEMCPY, epf_test->dma_chan_tx->device->cap_mask)) {
+			dev_err(dev, "DMA controller doesn't support MEMCPY\n");
 			ret = -EINVAL;
 			goto set_status;
 		}




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux