From: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
commit 54d394905c92b9ecc65c1f9b2692c8e10716d8e1 upstream.
This device returns signed, 16-bit samples as stated in its datasheet
(see 8.5.2 Data Format). That is in line with the scan_type definition
for the IIO_VOLTAGE channel, but 'unsigned int' is being used to read
and push the data to userspace.
Given that the size of that type depends on the architecture (at least
2 bytes to store values up to 65535, but its actual size is often 4
bytes), use the 's16' type to provide the same structure in all cases.
Fixes: a9306887eba4 ("iio: adc: ti-ads1119: Add driver")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
Reviewed-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
Link: https://patch.msgid.link/20241202-ti-ads1119_s16_chan-v1-1-fafe3136dc90@xxxxxxxxx
Cc: <Stable@xxxxxxxxxxxxxxx>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/iio/adc/ti-ads1119.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/ti-ads1119.c b/drivers/iio/adc/ti-ads1119.c
index 2615a275acb3..c268e27eec12 100644
--- a/drivers/iio/adc/ti-ads1119.c
+++ b/drivers/iio/adc/ti-ads1119.c
@@ -500,7 +500,7 @@ static irqreturn_t ads1119_trigger_handler(int irq, void *private)
struct iio_dev *indio_dev = pf->indio_dev;
struct ads1119_state *st = iio_priv(indio_dev);
struct {
- unsigned int sample;
+ s16 sample;
s64 timestamp __aligned(8);
} scan;
unsigned int index;
--
2.48.0
Patches currently in stable-queue which might be from javier.carrasco.cruz@xxxxxxxxx are
queue-6.12/iio-pressure-zpa2326-fix-information-leak-in-triggered-buffer.patch
queue-6.12/iio-adc-ti-ads1119-fix-sample-size-in-scan-struct-for-triggered-buffer.patch
queue-6.12/iio-adc-ti-ads1119-fix-information-leak-in-triggered-buffer.patch
queue-6.12/iio-dummy-iio_simply_dummy_buffer-fix-information-leak-in-triggered-buffer.patch
queue-6.12/iio-imu-kmx61-fix-information-leak-in-triggered-buffer.patch
queue-6.12/iio-adc-rockchip_saradc-fix-information-leak-in-triggered-buffer.patch
queue-6.12/cpuidle-riscv-sbi-fix-device-node-release-in-early-e.patch
queue-6.12/iio-light-bh1745-fix-information-leak-in-triggered-buffer.patch
queue-6.12/iio-light-vcnl4035-fix-information-leak-in-triggered-buffer.patch
queue-6.12/iio-adc-ti-ads8688-fix-information-leak-in-triggered-buffer.patch
