From: Matthieu Baerts (NGI0) <matttbe@xxxxxxxxxx>
commit 771ec78dc8b48d562e6015bb535ed3cd37043d78 upstream.
'net.mptcp.available_schedulers' sysctl knob is there to list available
schedulers, not to modify this list.
There are then no reasons to give write access to it.
Nothing would have been written anyway, but no errors would have been
returned, which is unexpected.
Fixes: 73c900aa3660 ("mptcp: add net.mptcp.available_schedulers")
Cc: stable@xxxxxxxxxxxxxxx
Reviewed-by: Mat Martineau <martineau@xxxxxxxxxx>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@xxxxxxxxxx>
Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>
Link: https://patch.msgid.link/20250108-net-sysctl-current-nsproxy-v1-1-5df34b2083e8@xxxxxxxxxx
Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
net/mptcp/ctrl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mptcp/ctrl.c b/net/mptcp/ctrl.c
index 38d8121331d4..d9b57fab2a13 100644
--- a/net/mptcp/ctrl.c
+++ b/net/mptcp/ctrl.c
@@ -228,7 +228,7 @@ static struct ctl_table mptcp_sysctl_table[] = {
{
.procname = "available_schedulers",
.maxlen = MPTCP_SCHED_BUF_MAX,
- .mode = 0644,
+ .mode = 0444,
.proc_handler = proc_available_schedulers,
},
{
--
2.48.0
Patches currently in stable-queue which might be from matttbe@xxxxxxxxxx are
queue-6.12/sctp-sysctl-plpmtud_probe_interval-avoid-using-current-nsproxy.patch
queue-6.12/sctp-sysctl-rto_min-max-avoid-using-current-nsproxy.patch
queue-6.12/mptcp-sysctl-avail-sched-remove-write-access.patch
queue-6.12/sctp-sysctl-auth_enable-avoid-using-current-nsproxy.patch
queue-6.12/sctp-sysctl-udp_port-avoid-using-current-nsproxy.patch
queue-6.12/mptcp-sysctl-sched-avoid-using-current-nsproxy.patch
queue-6.12/rds-sysctl-rds_tcp_-rcv-snd-buf-avoid-using-current-nsproxy.patch
queue-6.12/sctp-sysctl-cookie_hmac_alg-avoid-using-current-nsproxy.patch
queue-6.12/mptcp-sysctl-blackhole-timeout-avoid-using-current-nsproxy.patch
