On Fri, Jan 10, 2025 at 04:06:59PM +0000, Chris Clayton wrote: > Hi Greg (et al) > > On 10/01/2025 12:43, gregkh@xxxxxxxxxxxxxxxxxxx wrote: > > > > This is a note to let you know that I've just added the patch titled > > > > Revert "x86, crash: wrap crash dumping code into crash related ifdefs" > > > > to the 6.6-stable tree which can be found at: > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > > > The filename of the patch is: > > revert-x86-crash-wrap-crash-dumping-code-into-crash-related-ifdefs.patch > > and it can be found in the queue-6.6 subdirectory. > > > > If you, or anyone else, feels it should not be added to the stable tree, > > please let <stable@xxxxxxxxxxxxxxx> know about it. > > > > > > From 129885ec461fd82348e557524b087496947532fe Mon Sep 17 00:00:00 2001 > > From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > Date: Fri, 10 Jan 2025 13:09:11 +0100 > > Subject: Revert "x86, crash: wrap crash dumping code into crash related ifdefs" > > > > From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > > > This reverts commit e5b1574a8ca28c40cf53eda43f6c3b016ed41e27 which is > > commit a4eeb2176d89fdf2785851521577b94b31690a60 upstream. > > > > When this change is backported to the 6.6.y tree, it can cause build > > errors on some configurations when KEXEC is not enabled, so revert it > > for now. > > > > This changelog appears not to reflect the settings in the config I sent because in that config KEXEC is enabled. > > The kexec and crash related lines are: > > # > # Kexec and crash features > # > CONFIG_CRASH_CORE=y > CONFIG_KEXEC_CORE=y > CONFIG_KEXEC=y > # CONFIG_KEXEC_FILE is not set > # CONFIG_KEXEC_JUMP is not set > # CONFIG_CRASH_DUMP is not set > # end of Kexec and crash features You are right, I was having to mess with the KEXEC lines and the CRASH dump options and got them confused when writing the changelog text later on after many kernel test builds. It's when KEXEC _is_ enabled, and when CRASH_DUMP is not. Sorry for that. greg k-h
