Patch "ALSA: control: Avoid WARN() for symlink errors" has been added to the 6.12-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    ALSA: control: Avoid WARN() for symlink errors

to the 6.12-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     alsa-control-avoid-warn-for-symlink-errors.patch
and it can be found in the queue-6.12 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 752454fd9dfb90546d296a567878dc585f7e81a4
Author: Takashi Iwai <tiwai@xxxxxxx>
Date:   Mon Dec 9 10:56:12 2024 +0100

    ALSA: control: Avoid WARN() for symlink errors
    
    [ Upstream commit b2e538a9827dd04ab5273bf4be8eb2edb84357b0 ]
    
    Using WARN() for showing the error of symlink creations don't give
    more information than telling that something goes wrong, since the
    usual code path is a lregister callback from each control element
    creation.  More badly, the use of WARN() rather confuses fuzzer as if
    it were serious issues.
    
    This patch downgrades the warning messages to use the normal dev_err()
    instead of WARN().  For making it clearer, add the function name to
    the prefix, too.
    
    Fixes: a135dfb5de15 ("ALSA: led control - add sysfs kcontrol LED marking layer")
    Reported-by: syzbot+4e7919b09c67ffd198ae@xxxxxxxxxxxxxxxxxxxxxxxxx
    Closes: https://lore.kernel.org/675664c7.050a0220.a30f1.018c.GAE@xxxxxxxxxx
    Link: https://patch.msgid.link/20241209095614.4273-1-tiwai@xxxxxxx
    Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/sound/core/control_led.c b/sound/core/control_led.c
index 65a1ebe87776..e33dfcf863cf 100644
--- a/sound/core/control_led.c
+++ b/sound/core/control_led.c
@@ -668,10 +668,16 @@ static void snd_ctl_led_sysfs_add(struct snd_card *card)
 			goto cerr;
 		led->cards[card->number] = led_card;
 		snprintf(link_name, sizeof(link_name), "led-%s", led->name);
-		WARN(sysfs_create_link(&card->ctl_dev->kobj, &led_card->dev.kobj, link_name),
-			"can't create symlink to controlC%i device\n", card->number);
-		WARN(sysfs_create_link(&led_card->dev.kobj, &card->card_dev.kobj, "card"),
-			"can't create symlink to card%i\n", card->number);
+		if (sysfs_create_link(&card->ctl_dev->kobj, &led_card->dev.kobj,
+				      link_name))
+			dev_err(card->dev,
+				"%s: can't create symlink to controlC%i device\n",
+				 __func__, card->number);
+		if (sysfs_create_link(&led_card->dev.kobj, &card->card_dev.kobj,
+				      "card"))
+			dev_err(card->dev,
+				"%s: can't create symlink to card%i\n",
+				__func__, card->number);
 
 		continue;
 cerr:




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux