Re: Patch "platform/x86: asus-wmi: Fix thermal profile initialization" has been added to the 6.6-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 12.12.24 um 14:18 schrieb gregkh@xxxxxxxxxxxxxxxxxxx:

This is a note to let you know that I've just added the patch titled

     platform/x86: asus-wmi: Fix thermal profile initialization

to the 6.6-stable tree which can be found at:
     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
      platform-x86-asus-wmi-fix-thermal-profile-initialization.patch
and it can be found in the queue-6.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.


 From b012170fed282151f7ba8988a347670c299f5ab3 Mon Sep 17 00:00:00 2001
From: Armin Wolf <W_Armin@xxxxxx>
Date: Fri, 25 Oct 2024 21:15:13 +0200
Subject: platform/x86: asus-wmi: Fix thermal profile initialization

From: Armin Wolf <W_Armin@xxxxxx>

commit b012170fed282151f7ba8988a347670c299f5ab3 upstream.

When support for vivobook fan profiles was added, the initial
call to throttle_thermal_policy_set_default() was removed, which
however is necessary for full initialization.

Fix this by calling throttle_thermal_policy_set_default() again
when setting up the platform profile.

AFAIK the offending commit was never backported to the 6.6-stable tree, so this commit
is mot necessary here since the original call to throttle_thermal_policy_set_default() is
still present.

Thanks, Armin Wolf


Fixes: bcbfcebda2cb ("platform/x86: asus-wmi: add support for vivobook fan profiles")
Reported-by: Michael Larabel <Michael@xxxxxxxxxxxx>
Closes: https://www.phoronix.com/review/lunar-lake-xe2/5
Signed-off-by: Armin Wolf <W_Armin@xxxxxx>
Link: https://lore.kernel.org/r/20241025191514.15032-2-W_Armin@xxxxxx
Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
  drivers/platform/x86/asus-wmi.c |   10 ++++++++++
  1 file changed, 10 insertions(+)

--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86/asus-wmi.c
@@ -3569,6 +3569,16 @@ static int platform_profile_setup(struct
  	if (!asus->throttle_thermal_policy_dev)
  		return 0;

+	/*
+	 * We need to set the default thermal profile during probe or otherwise
+	 * the system will often remain in silent mode, causing low performance.
+	 */
+	err = throttle_thermal_policy_set_default(asus);
+	if (err < 0) {
+		pr_warn("Failed to set default thermal profile\n");
+		return err;
+	}
+
  	dev_info(dev, "Using throttle_thermal_policy for platform_profile support\n");

  	asus->platform_profile_handler.profile_get = asus_wmi_platform_profile_get;


Patches currently in stable-queue which might be from W_Armin@xxxxxx are

queue-6.6/platform-x86-asus-wmi-ignore-return-value-when-writi.patch
queue-6.6/platform-x86-asus-wmi-fix-inconsistent-use-of-therma.patch
queue-6.6/platform-x86-asus-wmi-fix-thermal-profile-initialization.patch





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux