On Wed, Dec 11, 2024 at 08:09:51PM +0100, Thomas Gleixner wrote: > > From: Manivannan Sadhasivam <mani@xxxxxxxxxx> > > commit 64506b3d23a337e98a74b18dcb10c8619365f2bd upstream. > > Otherwise, it will result in a NULL pointer dereference as below: > > Unable to handle kernel NULL pointer dereference at virtual address 0000000000000008 > Call trace: > mutex_lock+0xc/0x54 > platform_device_msi_free_irqs_all+0x14/0x20 > ufs_qcom_remove+0x34/0x48 [ufs_qcom] > platform_remove+0x28/0x44 > device_remove+0x4c/0x80 > device_release_driver_internal+0xd8/0x178 > driver_detach+0x50/0x9c > bus_remove_driver+0x6c/0xbc > driver_unregister+0x30/0x60 > platform_driver_unregister+0x14/0x20 > ufs_qcom_pltform_exit+0x18/0xb94 [ufs_qcom] > __arm64_sys_delete_module+0x180/0x260 > invoke_syscall+0x44/0x100 > el0_svc_common.constprop.0+0xc0/0xe0 > do_el0_svc+0x1c/0x28 > el0_svc+0x34/0xdc > el0t_64_sync_handler+0xc0/0xc4 > el0t_64_sync+0x190/0x194 > > Cc: stable@xxxxxxxxxxxxxxx # 6.3 > Fixes: 519b6274a777 ("scsi: ufs: qcom: Add MCQ ESI config vendor specific ops") > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > Link: https://lore.kernel.org/r/20241111-ufs_bug_fix-v1-2-45ad8b62f02e@xxxxxxxxxx > Reviewed-by: Bean Huo <beanhuo@xxxxxxxxxx> > Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx> > Signed-off-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx> > Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > --- > drivers/ufs/host/ufs-qcom.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Thanks for this, I've dropped the other backports and just taken this one instead. greg k-h