From: Jordy Zomer <jordyzomer@xxxxxxxxxx>
commit fc342cf86e2dc4d2edb0fc2ff5e28b6c7845adb9 upstream.
An offset from client could be a negative value, It could lead
to an out-of-bounds read from the stream_buf.
Note that this issue is coming when setting
'vfs objects = streams_xattr parameter' in ksmbd.conf.
Cc: stable@xxxxxxxxxxxxxxx # v5.15+
Reported-by: Jordy Zomer <jordyzomer@xxxxxxxxxx>
Signed-off-by: Jordy Zomer <jordyzomer@xxxxxxxxxx>
Signed-off-by: Namjae Jeon <linkinjeon@xxxxxxxxxx>
Signed-off-by: Steve French <stfrench@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
fs/smb/server/smb2pdu.c | 4 ++++
1 file changed, 4 insertions(+)
--- a/fs/smb/server/smb2pdu.c
+++ b/fs/smb/server/smb2pdu.c
@@ -6370,6 +6370,10 @@ int smb2_read(struct ksmbd_work *work)
}
offset = le64_to_cpu(req->Offset);
+ if (offset < 0) {
+ err = -EINVAL;
+ goto out;
+ }
length = le32_to_cpu(req->Length);
mincount = le32_to_cpu(req->MinimumCount);
Patches currently in stable-queue which might be from jordyzomer@xxxxxxxxxx are
queue-6.1/ksmbd-fix-out-of-bounds-write-in-ksmbd_vfs_stream_write.patch
queue-6.1/ksmbd-fix-out-of-bounds-read-in-ksmbd_vfs_stream_read.patch
