From: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
commit ee1dfbdd8b4b6de85e96ae2059dc9c1bdb6b49b5 upstream.
In commit 6e86a1543c37 ("can: dev: provide optional GPIO based
termination support") GPIO based termination support was added.
For no particular reason that patch uses gpiod_set_value() to set the
GPIO. This leads to the following warning, if the systems uses a
sleeping GPIO, i.e. behind an I2C port expander:
| WARNING: CPU: 0 PID: 379 at /drivers/gpio/gpiolib.c:3496 gpiod_set_value+0x50/0x6c
| CPU: 0 UID: 0 PID: 379 Comm: ip Not tainted 6.11.0-20241016-1 #1 823affae360cc91126e4d316d7a614a8bf86236c
Replace gpiod_set_value() by gpiod_set_value_cansleep() to allow the
use of sleeping GPIOs.
Cc: Nicolai Buchwitz <nb@xxxxxxxxxxx>
Cc: Lino Sanfilippo <l.sanfilippo@xxxxxxxxxx>
Cc: stable@xxxxxxxxxxxxxxx
Reported-by: Leonard Göhrs <l.goehrs@xxxxxxxxxxxxxx>
Tested-by: Leonard Göhrs <l.goehrs@xxxxxxxxxxxxxx>
Fixes: 6e86a1543c37 ("can: dev: provide optional GPIO based termination support")
Link: https://patch.msgid.link/20241121-dev-fix-can_set_termination-v1-1-41fa6e29216d@xxxxxxxxxxxxxx
Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/net/can/dev/dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/can/dev/dev.c
+++ b/drivers/net/can/dev/dev.c
@@ -409,7 +409,7 @@ static int can_set_termination(struct ne
else
set = 0;
- gpiod_set_value(priv->termination_gpio, set);
+ gpiod_set_value_cansleep(priv->termination_gpio, set);
return 0;
}
Patches currently in stable-queue which might be from mkl@xxxxxxxxxxxxxx are
queue-5.15/can-peak_usb-canfd-store-64-bits-hw-timestamps.patch
queue-5.15/can-do-not-increase-rx-statistics-when-generating-a-.patch
queue-5.15/can-j1939-j1939_session_new-fix-skb-reference-counti.patch
queue-5.15/can-dev-can_set_termination-allow-sleeping-gpios.patch
queue-5.15/can-j1939-fix-error-in-j1939-documentation.patch
queue-5.15/can-m_can-m_can_handle_lec_err-fix-rx-tx-_errors-sta.patch
queue-5.15/can-c_can-c_can_handle_bus_err-update-statistics-if-.patch
queue-5.15/can-ems_usb-ems_usb_rx_err-fix-rx-tx-_errors-statist.patch
queue-5.15/can-sun4i_can-sun4i_can_err-fix-rx-tx-_errors-statis.patch
queue-5.15/can-sun4i_can-sun4i_can_err-call-can_change_state-ev.patch
queue-5.15/can-ifi_canfd-ifi_canfd_handle_lec_err-fix-rx-tx-_er.patch
