From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
commit a508ef4b1dcc82227edc594ffae583874dd425d7 upstream.
The output of ".%03u" with the unsigned int in range [0, 4294966295] may
get truncated if the target buffer is not 12 bytes. This can't really
happen here as the 'remainder' variable cannot exceed 999 but the
compiler doesn't know it. To make it happy just increase the buffer to
where the warning goes away.
Fixes: 3c9f3681d0b4 ("[SCSI] lib: add generic helper to print sizes rounded to the correct SI range")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>
Cc: James E.J. Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>
Cc: Kees Cook <kees@xxxxxxxxxx>
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Link: https://lore.kernel.org/r/20241101205453.9353-1-brgl@xxxxxxxx
Signed-off-by: Kees Cook <kees@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
lib/string_helpers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/lib/string_helpers.c
+++ b/lib/string_helpers.c
@@ -57,7 +57,7 @@ int string_get_size(u64 size, u64 blk_si
static const unsigned int rounding[] = { 500, 50, 5 };
int i = 0, j;
u32 remainder = 0, sf_cap;
- char tmp[8];
+ char tmp[12];
const char *unit;
tmp[0] = '\0';
Patches currently in stable-queue which might be from bartosz.golaszewski@xxxxxxxxxx are
queue-6.12/gpio-sloppy-logic-analyzer-remove-reference-to-rcu_m.patch
queue-6.12/lib-string_helpers-silence-snprintf-output-truncation-warning.patch
queue-6.12/mmc-mmc_spi-drop-buggy-snprintf.patch
queue-6.12/gpio-zevio-add-missed-label-initialisation.patch
queue-6.12/pinctrl-zynqmp-drop-excess-struct-member-description.patch
queue-6.12/power-sequencing-make-the-qcom-pmu-pwrseq-driver-dep.patch
queue-6.12/gpio-exar-set-value-when-external-pull-up-or-pull-down-is-present.patch
