From: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
commit 9c41f371457bd9a24874e3c7934d9745e87fbc58 upstream.
The device_for_each_child_node() macro requires explicit calls to
fwnode_handle_put() upon early exits (return, break, goto) to decrement
the fwnode's refcount, and avoid levaing a node reference behind.
Add the missing fwnode_handle_put() after the common label for all error
paths.
Cc: stable@xxxxxxxxxxxxxxx
Fixes: fdc6b21e2444 ("platform/chrome: Add Type C connector class driver")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
Link: https://lore.kernel.org/r/20241013-cross_ec_typec_fwnode_handle_put-v2-1-9182b2cd7767@xxxxxxxxx
Signed-off-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/platform/chrome/cros_ec_typec.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -409,6 +409,7 @@ static int cros_typec_init_ports(struct
return 0;
unregister_ports:
+ fwnode_handle_put(fwnode);
cros_unregister_ports(typec);
return ret;
}
Patches currently in stable-queue which might be from javier.carrasco.cruz@xxxxxxxxx are
queue-6.11/leds-max5970-fix-unreleased-fwnode_handle-in-probe-f.patch
queue-6.11/wifi-brcmfmac-release-root-node-in-all-execution-paths.patch
queue-6.11/usb-typec-use-cleanup-facility-for-altmodes_node.patch
queue-6.11/bluetooth-btbcm-fix-missing-of_node_put-in-btbcm_get.patch
queue-6.11/platform-chrome-cros_ec_typec-fix-missing-fwnode-reference-decrement.patch
queue-6.11/clocksource-drivers-timer-ti-dm-fix-child-node-refco.patch
