Hi, <gregkh@xxxxxxxxxxxxxxxxxxx> 於 2024年12月2日 週一 下午11:32寫道： > > > This is a note to let you know that I've just added the patch titled > > xhci: Don't perform Soft Retry for Etron xHCI host > > to the 5.4-stable tree which can be found at: > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > The filename of the patch is: > xhci-don-t-perform-soft-retry-for-etron-xhci-host.patch > and it can be found in the queue-5.4 subdirectory. > > If you, or anyone else, feels it should not be added to the stable tree, > please let <stable@xxxxxxxxxxxxxxx> know about it. > Sorry, I'm new to this and not sure if I can reply to this email. This backport patch is incorrect because unlike the original upstream, both EJ168 and EJ188 require the XHCI_NO_SOFT_RETRY quirk to be applied. Please don't add it. > > From e735e957f2b9cfe4be486e0304732ec36928591f Mon Sep 17 00:00:00 2001 > From: Kuangyi Chiang <ki.chiang65@xxxxxxxxx> > Date: Wed, 6 Nov 2024 12:14:46 +0200 > Subject: xhci: Don't perform Soft Retry for Etron xHCI host > > From: Kuangyi Chiang <ki.chiang65@xxxxxxxxx> > > commit e735e957f2b9cfe4be486e0304732ec36928591f upstream. > > Since commit f8f80be501aa ("xhci: Use soft retry to recover faster from > transaction errors"), unplugging USB device while enumeration results in > errors like this: > > [ 364.855321] xhci_hcd 0000:0b:00.0: ERROR Transfer event for disabled endpoint slot 5 ep 2 > [ 364.864622] xhci_hcd 0000:0b:00.0: @0000002167656d70 67f03000 00000021 0c000000 05038001 > [ 374.934793] xhci_hcd 0000:0b:00.0: Abort failed to stop command ring: -110 > [ 374.958793] xhci_hcd 0000:0b:00.0: xHCI host controller not responding, assume dead > [ 374.967590] xhci_hcd 0000:0b:00.0: HC died; cleaning up > [ 374.973984] xhci_hcd 0000:0b:00.0: Timeout while waiting for configure endpoint command > > Seems that Etorn xHCI host can not perform Soft Retry correctly, apply > XHCI_NO_SOFT_RETRY quirk to disable Soft Retry and then issue is gone. > > This patch depends on commit a4a251f8c235 ("usb: xhci: do not perform > Soft Retry for some xHCI hosts"). > > Fixes: f8f80be501aa ("xhci: Use soft retry to recover faster from transaction errors") > Cc: stable@xxxxxxxxxxxxxxx > Signed-off-by: Kuangyi Chiang <ki.chiang65@xxxxxxxxx> > Signed-off-by: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx> > Link: https://lore.kernel.org/r/20241106101459.775897-21-mathias.nyman@xxxxxxxxxxxxxxx > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > --- > drivers/usb/host/xhci-pci.c | 1 + > 1 file changed, 1 insertion(+) > > --- a/drivers/usb/host/xhci-pci.c > +++ b/drivers/usb/host/xhci-pci.c > @@ -262,6 +262,7 @@ static void xhci_pci_quirks(struct devic > pdev->device == PCI_DEVICE_ID_EJ188) { > xhci->quirks |= XHCI_RESET_ON_RESUME; > xhci->quirks |= XHCI_BROKEN_STREAMS; > + xhci->quirks |= XHCI_NO_SOFT_RETRY; > } > > if (pdev->vendor == PCI_VENDOR_ID_RENESAS && > > > Patches currently in stable-queue which might be from ki.chiang65@xxxxxxxxx are > > queue-5.4/xhci-don-t-perform-soft-retry-for-etron-xhci-host.patch Thanks, Kuangyi Chiang
