From: Sibi Sankar <quic_sibis@xxxxxxxxxxx> commit 0bf020344204a2c1067b7562b6a247e6c689e28b upstream. The domain attributes returned by the perf protocol can end up reporting identical names across domains, resulting in debugfs node creation failure. Use the GENPD_FLAG_DEV_NAME_FW to ensure the genpd providers end up with an unique name. Logs: [X1E reports 'NCC' for all its scmi perf domains] debugfs: Directory 'NCC' with parent 'pm_genpd' already present! debugfs: Directory 'NCC' with parent 'pm_genpd' already present! Reported-by: Johan Hovold <johan+linaro@xxxxxxxxxx> Closes: https://lore.kernel.org/lkml/ZoQjAWse2YxwyRJv@xxxxxxxxxxxxxxxxxxxx/ Suggested-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> Signed-off-by: Sibi Sankar <quic_sibis@xxxxxxxxxxx> Cc: stable@xxxxxxxxxxxxxxx Message-ID: <20241030125512.2884761-6-quic_sibis@xxxxxxxxxxx> Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/pmdomain/arm/scmi_perf_domain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/pmdomain/arm/scmi_perf_domain.c +++ b/drivers/pmdomain/arm/scmi_perf_domain.c @@ -125,7 +125,8 @@ static int scmi_perf_domain_probe(struct scmi_pd->ph = ph; scmi_pd->genpd.name = scmi_pd->info->name; scmi_pd->genpd.flags = GENPD_FLAG_ALWAYS_ON | - GENPD_FLAG_OPP_TABLE_FW; + GENPD_FLAG_OPP_TABLE_FW | + GENPD_FLAG_DEV_NAME_FW; scmi_pd->genpd.set_performance_state = scmi_pd_set_perf_state; scmi_pd->genpd.attach_dev = scmi_pd_attach_dev; scmi_pd->genpd.detach_dev = scmi_pd_detach_dev; Patches currently in stable-queue which might be from quic_sibis@xxxxxxxxxxx are queue-6.11/pmdomain-core-add-genpd_flag_dev_name_fw-flag.patch queue-6.11/firmware-arm_scmi-skip-opp-duplicates.patch queue-6.11/mailbox-qcom-cpucp-mark-the-irq-with-irqf_no_suspend-flag.patch queue-6.11/pmdomain-arm-use-flag_dev_name_fw-to-ensure-unique-names.patch queue-6.11/firmware-arm_scmi-report-duplicate-opps-as-firmware-bugs.patch
