From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
commit d1aa0c04294e29883d65eac6c2f72fe95cc7c049 upstream.
Revert d949d1d14fa2 ("mm: shmem: fix data-race in shmem_getattr()") as
suggested by Chuck [1]. It is causing deadlocks when accessing tmpfs over
NFS.
As Hugh commented, "added just to silence a syzbot sanitizer splat: added
where there has never been any practical problem".
Link: https://lkml.kernel.org/r/ZzdxKF39VEmXSSyN@xxxxxxxxxxxxxxxxxxxxxx [1]
Fixes: d949d1d14fa2 ("mm: shmem: fix data-race in shmem_getattr()")
Acked-by: Hugh Dickins <hughd@xxxxxxxxxx>
Cc: Chuck Lever <chuck.lever@xxxxxxxxxx>
Cc: Jeongjun Park <aha310510@xxxxxxxxx>
Cc: Yu Zhao <yuzhao@xxxxxxxxxx>
Cc: <stable@xxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
mm/shmem.c | 2 --
1 file changed, 2 deletions(-)
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -1158,9 +1158,7 @@ static int shmem_getattr(struct mnt_idma
stat->attributes_mask |= (STATX_ATTR_APPEND |
STATX_ATTR_IMMUTABLE |
STATX_ATTR_NODUMP);
- inode_lock_shared(inode);
generic_fillattr(idmap, request_mask, inode, stat);
- inode_unlock_shared(inode);
if (shmem_is_huge(inode, 0, false, NULL, 0))
stat->blksize = HPAGE_PMD_SIZE;
Patches currently in stable-queue which might be from akpm@xxxxxxxxxxxxxxxxxxxx are
queue-6.6/nommu-pass-null-argument-to-vma_iter_prealloc.patch
queue-6.6/mm-fix-null-pointer-dereference-in-alloc_pages_bulk_noprof.patch
queue-6.6/nilfs2-fix-null-ptr-deref-in-block_dirty_buffer-tracepoint.patch
queue-6.6/tools-mm-fix-compile-error.patch
queue-6.6/ocfs2-fix-ubsan-warning-in-ocfs2_verify_volume.patch
queue-6.6/ocfs2-uncache-inode-which-has-failed-entering-the-group.patch
queue-6.6/nilfs2-fix-null-ptr-deref-in-block_touch_buffer-tracepoint.patch
queue-6.6/mm-revert-mm-shmem-fix-data-race-in-shmem_getattr.patch
